Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sozo] generate JSON manifest #1694

Merged
merged 9 commits into from
Mar 25, 2024
Merged

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Mar 24, 2024

Fixes #1665
Fixed DOJ-265

Generates the json manifest along with the toml. The json manifest has the ABI embedded.

@lambda-0x I have tried to have two structs, but it was too heavy. Hopefully this solution is not that ugly to you. :)

@glihm glihm changed the title Feat/json manifest [sozo] generate JSON manifest Mar 24, 2024
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 20.27027% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 68.26%. Comparing base (810b0f4) to head (9b33574).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/dojo-world/src/manifest.rs 20.00% 48 Missing ⚠️
crates/sozo/ops/src/migration/mod.rs 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1694      +/-   ##
==========================================
+ Coverage   68.09%   68.26%   +0.16%     
==========================================
  Files         273      274       +1     
  Lines       29509    29716     +207     
==========================================
+ Hits        20095    20286     +191     
- Misses       9414     9430      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lambda-0x lambda-0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from few comment, LGTM!

.gitignore Outdated Show resolved Hide resolved
crates/sozo/ops/src/migration/mod.rs Show resolved Hide resolved
examples/spawn-and-move/manifests/deployments/KATANA.json Outdated Show resolved Hide resolved
@glihm glihm requested a review from lambda-0x March 24, 2024 22:03
@glihm glihm merged commit 4a77ef7 into dojoengine:main Mar 25, 2024
11 of 12 checks passed
kariy pushed a commit that referenced this pull request Mar 28, 2024
* feat: add support for AbiFormat (path or embed)

* fix: add example updated manifests

* editor: add custom build commands

* fix: remove print and fmt + clippy

* add vscode settings to gitignore

* fix: ensure pretty formatting of the json

* chore: add all .vscode to gitignore

* chore: remove vscode tasks

* fix: enable PartialEq only for testing when required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sozo] output manifest format for client libraries
2 participants